Move to go 1.20 #114
Move to go 1.20 #114
Conversation
At least 1.18 is required to build the current source, to support the file embeding. 1.16 is the earliest with the feature, but the all:mgmt pattern doesn't work until 1.18.
| FROM golang:1.14.7 | ||
| MAINTAINER GitHub, Inc. | ||
| FROM golang:1.20 | ||
| LABEL org.opencontainers.image.authors=" GitHub, Inc." |
There was a problem hiding this comment.
I don't think it's accurate to say that GitHub is the author here, since this is an open source project and anyone can contribute, and you're contributing here. It's accurate that GitHub is the maintainer, so let's either back this change out or just remove the maintainer altogether.
There was a problem hiding this comment.
MAINTAINER is deprecated, with *.authors being the suggested replacement.
I get your point, though! Let me see if i can find a more suitable standard label.
If not, either removal or reverting is fine with me. Between the two, do you have a preference?
There was a problem hiding this comment.
OK, my thinking is to replace the text of *.authors with the first line of the LICENSE file, and supply the *.url, *.documentation, and *.source URLs, I guess pointing to the Dockerfile, README.md, and repo, respectively.
I'll see about making it a concrete change later (incorporating any feedback you may have by then).
Reference:
https://github.com/opencontainers/image-spec/blob/main/annotations.md
There was a problem hiding this comment.
(First line of the LICENSE file, to save you the trouble):
Copyright (c) GitHub, Inc. and LFS Test Server contributors
There was a problem hiding this comment.
I'd just remove the entry altogether in that case. I don't think it provides a lot of value in general.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Hey, please don't add unhelpful approvals and comments to existing PRs. If you don't stop, we'll have to block you. |
At least 1.18 is required to build the current source, to support the file embedding.
1.16 is the earliest with the feature, but the all:mgmt pattern doesn't work until 1.18.
(I might also suggest adding a Docker build of at least one platform to the release script. It would catch issues like this).