ARM64: fix /bin/bash.exe and /bin/sh.exe not starting
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is_running_on_arm64() currently checks two distinct things: - is this process running on ARM64 hardware? - is there a clangarm64/bin directory in the specified parent directory? While the answer to the first question won't change during execution, the answer to the second question can change depending on function parameters. We currently cache the result of both in one variable. Due to this, once we checked in one directory, we're ignoring all subsequent directories. This causes /bin/sh.exe and /bin/bash.exe to fail with the message "Top-level not found" on ARM64. To fix this, split is_running_on_arm64() into two parts and cache only the result of the hardware part. Signed-off-by: Matthias Aßhauer <[email protected]>
dennisameling
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a long standing known issue in @dennisameling test builds
Turns out it's a caching issue.