Skip to content

fix for Allow initialization once per run (with multiple modules) #53#143

Closed
dtrucken wants to merge 4 commits into
git-commit-id:masterfrom
dtrucken:master
Closed

fix for Allow initialization once per run (with multiple modules) #53#143
dtrucken wants to merge 4 commits into
git-commit-id:masterfrom
dtrucken:master

Conversation

@dtrucken

@dtrucken dtrucken commented Dec 3, 2014

Copy link
Copy Markdown
Contributor

Added a new optional configuration parameter ‘runOnlyOnce’

…-commit-id#53

Added a new optional configuration parameter ‘runOnlyOnce’

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe reword this: variables => maven properties?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, what ever maven calls these things: ${git.branch}, do you want me to
change the name and perform another commit ?

On Wed, Dec 3, 2014 at 9:51 AM, Konrad Malawski notifications@github.com
wrote:

In src/main/java/pl/project13/maven/git/GitCommitIdMojo.java:

@@ -257,6 +258,19 @@
private boolean skip = false;

/**

  • * In a multi-module build, only run once. This probably won't "do the right thing" if your project has more than
  • * one git repository. If you use this with the option 'generateGitPropertiesFile', it will only generate (or update)
  • * the file in the directory where you started your build.
  • * The git.* variables are available in all modules.

variables => maven properties?


Reply to this email directly or view it on GitHub
https://github.com/ktoso/maven-git-commit-id-plugin/pull/143/files#r21240166
.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap, thanks!

@ktoso

ktoso commented Dec 4, 2014

Copy link
Copy Markdown
Collaborator

Now only adding documentation in readme.md remains, would you be able to help out on that as well? Thanks!

@dtrucken

dtrucken commented Dec 4, 2014

Copy link
Copy Markdown
Contributor Author

hopefully enough for you to consider including this in the next release?

@ktoso

ktoso commented Dec 7, 2014

Copy link
Copy Markdown
Collaborator

Needs a bit more love, but I should be able to take it from here tomorrow and then cut a release.
Thanks for the contrib - it certainly makes sense for some scenarios.

@ktoso

ktoso commented Dec 8, 2014

Copy link
Copy Markdown
Collaborator

I'll merge manually - to keep this feature in one commit.
Would be nice to include a test for this.

@ktoso

ktoso commented Dec 8, 2014

Copy link
Copy Markdown
Collaborator

Merged manually 19918d4

@ktoso ktoso closed this Dec 8, 2014
@ktoso ktoso added this to the 2.1.12 milestone Dec 8, 2014
@ktoso ktoso self-assigned this Dec 8, 2014
@ktoso ktoso added the feature label Dec 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants