Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C_PP:Max sum_path_in_arrays #8714 #8715

Closed
wants to merge 14 commits into from

Conversation

monalsingh10
Copy link


Description 📜

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes #8714


Type of change 📝

  • Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
  • Vi#deo (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
  • Documentation (Content Creation in the form of codes or tutorials)
  • Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

  • Android Dev #(Flutter)
  • Android Dev #(Java)
  • Android Dev #(Kotlin)
  • Backend Dev #(Java)
  • Backend Dev #(.NET)
  • Backend Dev #(PHP)
  • Backend Dev #(Python)
  • C/CPP
  • Competitive #Programming
  • Cyber #Security
  • DS#A
  • Data#base
  • Datascience with #Python
  • Datascience with #R
  • Frontend Dev #HTML/CSS/JS
  • Frontend Dev #React/Angular/Vue
  • Go#lang
  • Interview #Prep
  • Java_#Domain
  • JavaScript_#Domain
  • ME#RN
  • Machine #Learning
  • Open #Source
  • Python_#Domain
  • Ru#st
  • Statis#tics
  • UI/#UX

Checklist ✅

  • I follow Contributing Guidelines & Code of conduct of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸


@keywordlabeler keywordlabeler bot added C/CPP documentation Improvements or additions to documentation GWOC21 labels Nov 28, 2021
@monalsingh10 monalsingh10 changed the title C cpp C_PP:Max sum_path_in_arrays #8714 Nov 28, 2021
@gunjan-g
Copy link
Contributor

@monalsingh10 why you've added extra files?

@monalsingh10
Copy link
Author

It's an pr

@gunjan-g
Copy link
Contributor

It's an pr

All the files for the same issue?

@monalsingh10
Copy link
Author

No.For every file there is an separate issue.

Copy link
Member

@Suvraneel Suvraneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monalsingh10 there's way too many things wrong in this PR :

  1. Wrong path ... viz -
    image

  2. 1 PR fixes ONLY 1 issue
    image
    So, this is supposed to show 2 files only :
    1 md file for documentation/audio/video contrib another as line added to readme.md

  3. : is an illegal pathname character in Windows

  4. Next time you make a PR, go through Roadmap & directory structure of a project to find appropriate directory & then push files to that directory

Anyway, closing this

@Suvraneel Suvraneel closed this Nov 29, 2021
@Suvraneel Suvraneel added the invalid This doesn't seem right label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C/CPP documentation Improvements or additions to documentation GWOC21 invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants