Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made The Navbar #45

Closed
wants to merge 2 commits into from
Closed

Made The Navbar #45

wants to merge 2 commits into from

Conversation

musk101
Copy link
Contributor

@musk101 musk101 commented Mar 20, 2021

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.

Closes #35

Type of change

Please delete options that are not relevant.

  • added the navbar according to the design provided.
  • I have added 2 things in src folder index.js and NavbarElement.js under the components folder.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @musk101 Please do the following

  1. Resolve the conflict by pulling the latest changes
  2. Never add node_modules in staging/commit. So please revert that using git checkout HEAD -- <node_module_path> You can read more about it here

@musk101
Copy link
Contributor Author

musk101 commented Mar 21, 2021

okay i will make the changes.

@musk101
Copy link
Contributor Author

musk101 commented Mar 31, 2021

Hello, @Kajol-Kumari sorry for the delay I have linked PR #77 that resolves the issue.
I have made changes in navbar and made the footer.
Thankyou.

@musk101 musk101 closed this Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Navbar
2 participants