Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump OpenSSL #51

Closed
wants to merge 1 commit into from
Closed

fix: Bump OpenSSL #51

wants to merge 1 commit into from

Conversation

asmacdo
Copy link
Contributor

@asmacdo asmacdo commented Nov 1, 2023

With 1.1.1l there were build errors. This change was first proposed in #49 by @tazend, but that also included other features.

FWIW, the reason I needed to rebuild was to override some slurm.conf which @tazend has added an interface for, so big +1 on that :)

With main I had the following output when building the container:

Test Summary Report                                                                                                                   	 
-------------------                                                                                                                   	 
../test/recipes/80-test_cms.t                	(Wstat: 1280 Tests: 6 Failed: 5)                                                     	 
  Failed tests:  1-5                                                                                                                  	 
  Non-zero exit status: 5                                                                                                             	 
../test/recipes/80-test_ssl_new.t            	(Wstat: 256 Tests: 29 Failed: 1)                                                     	 
  Failed test:  12                                                                                                                    	 
  Non-zero exit status: 1                                                                                                             	 
Files=158, Tests=2636, 75 wallclock secs ( 1.97 usr  0.24 sys + 64.14 cusr 18.56 csys = 84.91 CPU)                                    	 
Result: FAIL                                                                                                                          	 
make[1]: *** [_tests] Error 1                                                                                                         	 
make[1]: Leaving directory `/openssl-1.1.1l'                                                                                          	 
make: *** [tests] Error 2                                                                                                             	 
Error: building at STEP "RUN set -ex 	&& wget --quiet https://www.openssl.org/source/openssl-${OPENSSL_VERSION}.tar.gz 	&& tar xzf op
enssl-${OPENSSL_VERSION}.tar.gz 	&& pushd openssl-${OPENSSL_VERSION} 	&& ./config --prefix=/opt/openssl --openssldir=/etc/ssl 	&&
make 	&& make test 	&& make install 	&& echo "/opt/openssl/lib" >> /etc/ld.so.conf.d/openssl.conf 	&& ldconfig 	&& popd	 
&& rm -rf openssl-${OPENSSL_VERSION}.tar.gz": while running runtime: exit status 2

With this change, the rebuild completes successfully.

With 1.1.1l there were build errors. This change was first proposed
in giovtorres#49 by tazend,
but that also included other features.
@giovtorres
Copy link
Owner

I merged #49, so i dont think this is needed anymore.

@asmacdo asmacdo closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants