Fix issues reported by testifylint #4116
Open
+22
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -998,7 +998,7 @@ func TestContextRenderIndentedJSON(t *testing.T) { | |||
| c.IndentedJSON(http.StatusCreated, H{"foo": "bar", "bar": "foo", "nested": H{"foo": "bar"}}) | |||
|
|
|||
| assert.Equal(t, http.StatusCreated, w.Code) | |||
| assert.Equal(t, "{\n \"bar\": \"foo\",\n \"foo\": \"bar\",\n \"nested\": {\n \"foo\": \"bar\"\n }\n}", w.Body.String()) | |||
| assert.JSONEq(t, "{\n \"bar\": \"foo\",\n \"foo\": \"bar\",\n \"nested\": {\n \"foo\": \"bar\"\n }\n}", w.Body.String()) | |||
There was a problem hiding this comment.
This regresses the test. JSONEq will ignore the formatting but this test asserts that the body is indented JSON.
There was a problem hiding this comment.
Which testifylint rule was this? And with which version of testifylint?
I'd like to raise this an issue on the linter but I can't replicate the behaviour.
There was a problem hiding this comment.
Which testifylint rule was this? And with which version of testifylint?
testifylint -V=full
/usr/local/bin/testifylint version devel comments-go-here buildID=b4feaeeee0471267f317aa4baaca3111987511befe6032bbd9b54f9f7a9f0923
Please note that the switch -V of testifylint is broken, there exists an issue for that already.
I'd like to raise this an issue on the linter but I can't replicate the behaviour.
Please have a look at this workflow run which clearly shows the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues reported from testifylint.