-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form): add array collection format in form binding #3986
Conversation
Just saw the old PR you linked and was excited to see that someone else took up the old dead PR to make this a feature in gin. Looking forward to getting this merged! |
Thank you for your comments. @takanuva15 |
@slowhigh Any updates? |
@appleboy Thank you. Good idea. |
@appleboy I have addressed the lint error you mentioned. |
@slowhigh LGTM |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3986 +/- ##
==========================================
- Coverage 99.21% 98.85% -0.36%
==========================================
Files 42 44 +2
Lines 3182 2799 -383
==========================================
- Hits 3157 2767 -390
- Misses 17 19 +2
- Partials 8 13 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Enables the possibility of collecting array data from queries or form data by specifying the collection_format tag in structs.
Several people are waiting for this feature to be updated.
cc @Simon-Saaw
Related PR: #2750
Close #2750