fix: server-sent-event example should use c.Writer.CloseNotify() chan #169
+239
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleboy
approved these changes
Nov 13, 2024
|
@justintoman Please resolve the conflicts |
justintoman
force-pushed
the
fix/server-sent-event-close-notify
branch
from
1e618be to
bc9b555
Compare
appleboy
approved these changes
Dec 18, 2024
|
Please resolve again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was basing an app off this example, and I was noticing that clients weren't getting closed until I tried (and failed) to send messages to disconnected clients.
Example: I'm connected to the SSE stream, then close the browser window. The
log.Printf("Removed client")doesn't show up until after I try to send the next message to closed browser window.Using
c.Writer.CloseNotify()appears to work immediately.