Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AbortWithStatus): the middleware is unable to successfully set the http headers once calling gin.Context.AbortWithStatus #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhyee
Copy link
Contributor

@zhyee zhyee commented Mar 5, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.72%. Comparing base (1d781d2) to head (089ace3).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
writer.go 16.66% 4 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   95.27%   91.72%   -3.55%     
==========================================
  Files           4        4              
  Lines         127      133       +6     
==========================================
+ Hits          121      122       +1     
- Misses          4        8       +4     
- Partials        2        3       +1     
Flag Coverage Δ
go-1.18 ?
go-1.21 91.72% <16.66%> (-3.55%) ⬇️
go-1.22 89.47% <16.66%> (?)
go-1.23 91.72% <16.66%> (?)
go-1.24 91.72% <16.66%> (?)
ubuntu-latest 91.72% <16.66%> (-3.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…e http headers once calling gin.Context.AbortWithStatus
@zhyee zhyee force-pushed the fix-abort_with_status-call branch from 905600d to 74f775a Compare March 5, 2025 15:02
@zhyee zhyee force-pushed the fix-abort_with_status-call branch from e24ebde to 089ace3 Compare March 10, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants