Inserting numeric values (making it possible to write serial number dates/times)#379
Open
Drowze wants to merge 1 commit intogimite:masterfrom
Open
Inserting numeric values (making it possible to write serial number dates/times)#379Drowze wants to merge 1 commit intogimite:masterfrom
Drowze wants to merge 1 commit intogimite:masterfrom
Conversation
Drowze
added a commit
to Drowze/aspirebudgeting_ruby
that referenced
this pull request
Jul 24, 2020
PR open at: gimite/google-drive-ruby#379 Also updated the spreadsheet mock with a way to input serial dates.
Drowze
added a commit
to Drowze/aspirebudgeting_ruby
that referenced
this pull request
Jul 24, 2020
PR open at: gimite/google-drive-ruby#379 Also - Update the spreadsheet mock with a way to input serial dates. - Remove core_extensions from coverage report.
Numeric values should added as-is and not converted to strings. This is specially important if the user is trying to add dates in their serial form.
85738f6 to
c9f1560
Compare
Drowze
added a commit
to Drowze/aspirebudgeting_ruby
that referenced
this pull request
Jul 25, 2020
PR open at: gimite/google-drive-ruby#379 Also - Update the spreadsheet mock with a way to input serial dates. - Remove core_extensions from coverage report.
Drowze
added a commit
to Drowze/aspirebudgeting_ruby
that referenced
this pull request
Jul 28, 2020
PR open at: gimite/google-drive-ruby#379 Also - Update the spreadsheet mock with a way to input serial dates. - Remove core_extensions from coverage report. - Remove CoreExtensions::Worksheet rubocop checking
Drowze
added a commit
to Drowze/aspirebudgeting_ruby
that referenced
this pull request
Jul 28, 2020
PR open at: gimite/google-drive-ruby#379 Also - Update the spreadsheet mock with a way to input serial dates. - Remove core_extensions from coverage report. - Remove CoreExtensions::Worksheet rubocop checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#380 - tests are passing
I had to patch
Worksheet#[]=method to, instead of setting@numeric_values[[row, cel]]always to nil, to set it to the value itself if it's a numeric value or nil otherwise. Having the numeric value saved, I can use it on#saveand that's enough for Google to parse the value as numeric if adequate.Worksheet#[]=andWorksheet#[]APIs should be untouched, whileWorksheet#numeric_valuebehaviour have changed a bit.before:
after: