Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objectstorage access alerts #1428

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Objectstorage access alerts #1428

merged 4 commits into from
Nov 19, 2024

Conversation

hervenicol
Copy link
Contributor

Towards: giantswarm/roadmap#3705

This PR adds some alerts to loki and mimir that check object storage access.

Checklist

@hervenicol hervenicol requested a review from a team as a code owner November 18, 2024 20:59
@hervenicol hervenicol requested review from a team and removed request for a team November 18, 2024 20:59
@hervenicol hervenicol self-assigned this Nov 18, 2024
description: '{{`Loki object storage write rate is down.`}}'
opsrecipe: loki/
expr: |
irate(loki_rate_store_stream_rate_bytes_count[5m]) == 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the second part of the expression?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will make sure the alert fires when the metrics don't exist.
I added a comment to explain it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good thinking. You might do this for loki canary because I think don't have that for them

Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hervenicol hervenicol merged commit 0c776f0 into main Nov 19, 2024
7 checks passed
@hervenicol hervenicol deleted the objectstorage-access-alerts branch November 19, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants