Add more test cases for sharding strategy #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| currentShardCount: 3, | ||
| timeSeries: float64(0), | ||
| expected: 3, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| func TestShardComputationLogic(t *testing.T) { |
There was a problem hiding this comment.
There is no need for parallel execution here
There was a problem hiding this comment.
Well yes, improving speed 😅
There was a problem hiding this comment.
with t.Parallel
$ time go test ./pkg/monitoring/prometheusagent/sharding/
ok github.com/giantswarm/observability-operator/pkg/monitoring/prometheusagent/sharding (cached)
go test ./pkg/monitoring/prometheusagent/sharding/ 0,11s user 0,05s system 192% cpu 0,084 total
without t.Parallel
$ time go test ./pkg/monitoring/prometheusagent/sharding/
ok github.com/giantswarm/observability-operator/pkg/monitoring/prometheusagent/sharding (cached)
go test ./pkg/monitoring/prometheusagent/sharding/ 0,11s user 0,08s system 175% cpu 0,104 total
I see no speed improvement, and even then tests do not need such "optimization". t.Parallel is also meant to be used in order to spot race conditions rather than improving speed.
There was a problem hiding this comment.
Well I disagree that tests should not run on parallel for ci costs and Time but hère they are probably not relevant
QuentinBisson
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: giantswarm/roadmap#3724
Adding more test cases for sharding strategy to cover more scenarios.