Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyperlinks to references #116

Closed
wants to merge 1 commit into from
Closed

Fix hyperlinks to references #116

wants to merge 1 commit into from

Conversation

koppor
Copy link
Member

@koppor koppor commented Jul 10, 2023

Fixes #107

(and minor adaptions to build.sh and wording at lni.dtx)

@koppor koppor mentioned this pull request Jul 10, 2023
@sieversMartin
Copy link
Member

I am not sure, whether loading in the middle of the preamble is a good idea. We should look for another solution IMHO.

@sieversMartin
Copy link
Member

We should keep the load order, but work with hyperref=manual and \BiblatexManualHyperrefOn. See https://github.com/gi-ev/LNI/tree/fix-107-ms

@koppor
Copy link
Member Author

koppor commented Jul 11, 2023

The fix looks nice! Thank you.

In general, we should think about supporting addition of packages, which need to be loaded after hyperref. A huge discussion is at https://tex.stackexchange.com/q/1863/9075. - I am very glad that no user reported issues in loading additional packages. I am unsure whether this is luck or because the class is properly engineered ^^.

Maybe using pkgloader could help? However, this is a solution not widely in use and may cause other issues.

@koppor
Copy link
Member Author

koppor commented Jul 11, 2023

I close this PR and will merge the other commit to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bibliography linking
2 participants