Out of bounds check

Out of bounds check for meshes. Signed-off-by: ghurstunither <[email protected]>
ghurstunither · Oct 11, 2024 · 7c753e5 · 7c753e5
1 parent 10fecd4
commit 7c753e5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/openvdb/openvdb/tools/LevelSetThickenedMesh.h b/openvdb/openvdb/tools/LevelSetThickenedMesh.h
@@ -1008,6 +1008,8 @@ class TriangleMeshEdgeConnectivity {
     TriangleMeshEdgeConnectivity(const std::vector<Vec3s>& coords, const std::vector<Vec3I>& cells)
     : mCoords(coords), mCells(cells)
     {
+        const Index n = coords.size();
+
         mNormals.resize(cells.size());
 
         for (Index i = 0; i < cells.size(); i++) {
@@ -1023,6 +1025,9 @@ class TriangleMeshEdgeConnectivity {
                 mEdgeMap[edge].push_back(i);
             }
 
+            if (cell[0] >= n || cell[1] >= n || cell[2] >= n)
+                OPENVDB_THROW(ValueError, "out of bounds index");
+
             const Vec3s &p1 = mCoords[cell[0]],
                         &p2 = mCoords[cell[1]],
                         &p3 = mCoords[cell[2]];

diff --git a/openvdb/openvdb/tools/LevelSetTubes.h b/openvdb/openvdb/tools/LevelSetTubes.h
@@ -1276,12 +1276,18 @@ class TubeComplexVoxelizer {
     inline void
     computeCentroids(std::vector<Vec3s>& centroids)
     {
+        const Index n = mCoords.size();
+
         centroids.resize(mCells.size());
 
         tbb::parallel_for(tbb::blocked_range<size_t>(0, centroids.size()),
             [&](const tbb::blocked_range<size_t>& r) {
                 for (size_t i = r.begin(); i != r.end(); ++i) {
                     const Vec2I &cell = mCells[i];
+
+                    if (cell[0] >= n || cell[1] >= n)
+                        OPENVDB_THROW(ValueError, "out of bounds index");
+
                     centroids[i] = 0.5f * (mCoords[cell[0]] + mCoords[cell[1]]);
                 }
             });