Add close tabs on the right action #9783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phaistonian
commented
Dec 2, 2025
phaistonian
commented
mitchellh
requested changes
Dec 11, 2025
Contributor
mitchellh
left a comment
mitchellh
left a comment
There was a problem hiding this comment.
Thanks for this. I think we should support this feature but I think we should make this macOS only for now because I'm not sure if it's typical for this to behave this way on GTK. We can easily add it later.
I'll see if I can clean this up.
Contributor
|
Actually just going to remove the context menu for now, the tab view API call is fine. |
mitchellh
force-pushed
the
feat/close-tabs-right
branch
from
fb758dd to
1387dbe
Compare
mitchellh
approved these changes
Dec 11, 2025
Contributor
There was a problem hiding this comment.
Great. I made some changes here:
- Removed GTK UI (but kept binding action functionality)
- Rename to "Close Tabs to the Right" instead of "on", because that's what Apple apps use
- Change to selector comparison for tab bar context menu detection
- Change to using an NSMenu extension so we can more easily add more stuff in the future
- Ensure the target is the correct target so you can right click non-focused tabs
- Added
xmarkicon to close targets to match Safari
tristan957
reviewed
Dec 11, 2025
Member
|
Very cool that macOS supports this. I can see from Chrome on macOS that the string is exactly the same. Awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.