fix(Metal): fix incorrect premultiplication of colors #5172
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure to divide alpha out before applying gamma encoding back to text color when not using linear blending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load_colorwas multiplying the alpha channel by itself as well, rather than just thergbchannels.Also made sure to divide alpha out before applying gamma encoding back to text color when not using linear blending, which was another source of error.
Probably fixes the problem observed in #5133 -- I couldn't reproduce the exact color shift, but did see a similar one with some of my test colors. This most visibly affects dimmed text since it uses an alpha of less than 1 for the text color.