Add toggle_background_opacity action for macOS
#5170
+69
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liby
force-pushed
the
feature/macos-toggle-background-opacity
branch
from
149ed06 to
354bd2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added
ghosttyBackgroundOpacityDidTogglenotification for handling opacity toggle eventsImplemented opacity toggle logic in
SurfaceView_AppKit.swiftIf
background-opacityis 1 or greater, do nothingTesting
Set
background-opacity< 1 in configBind a key to
toggle_background_opacityactionPress the key to toggle between transparent and opaque states
Verify that:
Window properly toggles between transparent and opaque states
Background color is correct in both states
Action does nothing when
background-opacityis 1 or moreAction does nothing in fullscreen mode
demo.mp4
Resolves #5047