Skip to content

docs: fix broken url in main readme #14371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

justinclift-prvidr
Copy link

Using the full url here gives a working result, whereas the existing url is broken.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Using the full url here gives a working result, whereas the existing url is broken.
@@ -457,7 +457,7 @@ To learn more about model quantization, [read this documentation](tools/quantize

</details>

[^1]: [tools/perplexity/README.md](./tools/perplexity/README.md)
[^1]: [tools/perplexity/README.md](https://github.com/ggml-org/llama.cpp/tree/master/tools/perplexity/README.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[^1]: [tools/perplexity/README.md](https://github.com/ggml-org/llama.cpp/tree/master/tools/perplexity/README.md)
[^1]: [tools/perplexity/README.md](tools/perplexity/README.md)

I think the problem was just the relative path (see other links here).

Copy link

@justinclift justinclift Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the first thing I tried, but the Preview in the GitHub editor gives that a broken link too so I didn't bother trying that approach further.

And yeah, the Preview DOESN'T break the near identical link in the header above it. Seems like a bug in the GitHub parser(s) somewhere.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funnily enough it's fine if you preview README.md.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a GitHub bug indeed, I suggest removing this footnote and linking the word perplexity directly instead, that seems to work just fine.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll get it done tomorrow when I'm back at work. 😄

@CISC
Copy link
Collaborator

CISC commented Jul 20, 2025

Sorry, fixed in #14780 now.

@CISC CISC closed this Jul 20, 2025
@justinclift-prvidr
Copy link
Author

It's all good. Work has been super busy lately and this was pretty far down the priority list. 😄

@justinclift-prvidr justinclift-prvidr deleted the patch-2 branch July 20, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants