-
Notifications
You must be signed in to change notification settings - Fork 12.5k
docs: fix broken url in main readme #14371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using the full url here gives a working result, whereas the existing url is broken.
@@ -457,7 +457,7 @@ To learn more about model quantization, [read this documentation](tools/quantize | |||
|
|||
</details> | |||
|
|||
[^1]: [tools/perplexity/README.md](./tools/perplexity/README.md) | |||
[^1]: [tools/perplexity/README.md](https://github.com/ggml-org/llama.cpp/tree/master/tools/perplexity/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[^1]: [tools/perplexity/README.md](https://github.com/ggml-org/llama.cpp/tree/master/tools/perplexity/README.md) | |
[^1]: [tools/perplexity/README.md](tools/perplexity/README.md) |
I think the problem was just the relative path (see other links here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the first thing I tried, but the Preview in the GitHub editor gives that a broken link too so I didn't bother trying that approach further.
And yeah, the Preview DOESN'T break the near identical link in the header above it. Seems like a bug in the GitHub parser(s) somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funnily enough it's fine if you preview README.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a GitHub bug indeed, I suggest removing this footnote and linking the word perplexity
directly instead, that seems to work just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'll get it done tomorrow when I'm back at work. 😄
Sorry, fixed in #14780 now. |
It's all good. Work has been super busy lately and this was pretty far down the priority list. 😄 |
Using the full url here gives a working result, whereas the existing url is broken.