scripts : support arbitrary input file formats in compare-llama-bench.py #13455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CISC
changed the title
There was a problem hiding this comment.
I think we should not have two parallel implementations for fetching data; either sqlite data should be using the generic implementation or JSON/JSONL data should be used to fill an SQL database. My personal preference would be SQL but I am willing to compromise depending on what other maintainers prefer.
Hm, ok, so an in-memory database then? |
|
Yes. |
|
Ok, done. |
JohannesGaessler
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored git/file handling into specialized classes to support arbitrary input file support.
The
-i/--inputparameter can now be invoked multiple times to load multiple files.If only a single file is specified, attempt to load it as SQLite3, JSON, JSONL or CSV, otherwise attempt to load multiple JSON or multiple CSV files.