Added support to select GPU using metal on Apple Intel or Apple Silicon using --main-gpu index #8962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifeanyipossibilities
commented
Aug 10, 2024
•
ifeanyipossibilities
commented
- I have read the contributing guidelines
- Self-reported review complexity:
- Low
- Medium
- High
github-actions
bot
added
examples
ggml
|
Added support to select GPU using metal on Apple Intel or Apple Silicon using --main-gpu index |
ggerganov
requested changes
Aug 10, 2024
mofosyne
added
the
Review Complexity : Low
slaren
reviewed
Aug 10, 2024
| @@ -3295,8 +3334,8 @@ void ggml_backend_metal_capture_next_compute(ggml_backend_t backend) { | |||
| GGML_CALL ggml_backend_t ggml_backend_reg_metal_init(const char * params, void * user_data); // silence warning | |||
|
|
|||
| GGML_CALL ggml_backend_t ggml_backend_reg_metal_init(const char * params, void * user_data) { | |||
| return ggml_backend_metal_init(); | |||
| return ggml_backend_metal_init((int) (intptr_t) user_data); | |||
There was a problem hiding this comment.
Where is the user_data set?
|
This is not the correct way to implement multiple device support. It would need a different buffer type for each device, and it would need to register one backend for each device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.