chore(cts): Fix parsing of Git for Windows version string #7814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git for Windows adds an extra suffix to the version string. This is a follow up to gfx-rs#7800 that ensures we parse such git versions correctly rather than returning an error.
ErichDonGubler
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
...I am similarly puzzled why the Windows check from the regressing PR passed! It very clearly says git version 2.49.0.windows.1 in the repo checkout step. 🥴
|
Sorry for the breakage! 🙏💦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Regressed by #7800
Description
Git for Windows adds an extra suffix to the version string. This is a follow up to #7800 that ensures we parse such git versions correctly rather than returning an error.
This is causing CTS runs to fail for me on CI. So I'm curious how it got through CI in the first place?
Testing
Added a test. CI now passes (presumably)
Squash or Rebase?
doesn't matter
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.