[Naga msl-out] Add padding to end of structs. And run some textureSample CTS tests that now pass #7804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamienicol
force-pushed
the
msl-struct-pad-end
branch
from
8344c76 to
59f5a2e
Compare
|
Marking as draft until I fix the test failures |
jamienicol
commented
Jun 13, 2025
| @@ -238,8 +238,7 @@ fn create_struct_layout_tests(storage_type: InputStorageType) -> Vec<ShaderTest> | |||
| &input_values, | |||
| &[0, 1, 2, 3, 4, 8, 9, 10, 11, 12], | |||
| ) | |||
| .header(header) | |||
| .failures(Backends::METAL), | |||
There was a problem hiding this comment.
@cwfitzgerald This PR seems to fix these tests. Since you added them, thought you might have opinions on whether this fix is correct? It doesn't really seem the same as described in #5262
jamienicol
commented
Jun 13, 2025
This was referenced Jun 13, 2025
This doesn't do anything yet, but unblocks running some CTS tests.
Limit to the `sampled_1d_coords` subtests for now as otherwise the tests take a very long time to execute, and there are also some failures with certain texture formats that are used in higher dimensions.
jamienicol
force-pushed
the
msl-struct-pad-end
branch
from
9901c01 to
e01ba35
Compare
|
Ready for review now |
6 tasks
jimblandy
approved these changes
Jun 17, 2025
|
@crowlKats approved the exact same deno changes in #7709 , so I think we can go ahead and land this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #7803
Depends on #7807
The deno changes are copied from #7709. If this lands first I'll remove the changes from that PR.
Description
See #7803
Note I've only enabled the 1d tests to run. In higher dimensions we use more exotic texture formats, some of which fail. They also take a very long time to run, so there's probably a discussion to be had about whether that's desirable.
Testing
Added CTS test to run
Squash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.