Deferred error reporting for command encoder operations #7798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
approved these changes
Jun 16, 2025
jimblandy
force-pushed
the
errors-on-finish-non-transfer
branch
from
67eb119 to
a25f58e
Compare
* clear commands * query set functions * command_encoder_as_hal_mut * ray_tracing
jimblandy
force-pushed
the
errors-on-finish-non-transfer
branch
from
a25f58e to
00fbfba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next piece of #7391. Based on (includes the commit from) #7794. This PR updates the rest of the command encoder operations for deferred error reporting.
Turning on the "hide whitespace" option will substantially reduce the diff.
Testing
Small update to tests, but most of the test coverage for this will be enabled later.
Squash or Rebase? Squash (but only after #7794 is merged)
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.