[naga] Always compact the module in process_overrides #7795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #7638, but I don't have a Windows system, so I can't 100% confirm that.
This change mostly avoids the issues in #7793 by only compacting (not attempting override resolution) if the module doesn't have any overrides. I've also optimized the case where there is only one entry point, although I'm not sure that's a good idea -- it may be possible to write a module with one entry point and a problematic global that is not used by the entry point, and we'd need to compact that module to get rid of the problematic global.
Testing
I'm open to suggestions what tests make sense here. I considered writing a test in
naga::validation
that verifies compaction has taken place, but it doesn't feel like it adds a lot of value. Possibly there are some tests that can be added with #7734, although it will be difficult to distinguish the effects of this change vs. #7626. We could also create a test based on the test case in #7638, but I don't have a windows machine to work on that.Squash or Rebase? Squash
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.