Make naga span methods take path as generic AsRef Path

[atlv24]

Connections
none

Description
These methods dont match naga/src/front/wgsl/error.rs and are harder to use than them.

Testing
It compiles.

Squash or Rebase?

Doesn't matter

Checklist

• Run cargo fmt.
• Run taplo format.
• Run cargo clippy --tests. If applicable, add:
  • --target wasm32-unknown-unknown
• Run cargo xtask test to run tests.
• If this contains user-facing changes, add a CHANGELOG.md entry.

[ErichDonGubler]

lgtm yo

…minus a teeny nit. 🙂 Approving conditional on resolution.

[ErichDonGubler]

Ahhh, but wait, just checked CI failures. The Windows one looks spurious, but the wasm32 build failure is a problem. These APIs exposed in no_std environments; no_std means no std::path::Path¹. 💦 We need to resolve this conflict to proceed.

😐 Sorry for the whiplash!

Footnotes

1. That seems counter-intuitive with the stderr name—CC @bushrat011899! ↩

[bushrat011899]

Re. no_std: I've created a little Gist here that I think solves the issue quite cleanly. The idea is to create a new trait, AsPath, which exposes the methods you need (e.g., to_string_lossy) and either:

• Blanket implement for anything implementing AsRef<Path> when std is available; or
• Specifically implement for the subset of types that implement AsRef<Path> but are available without std (e.g., String and str).

This ensures the std feature is still additive and gives the same ergonomic benefit to std users, and gives a lesser (but still positive) boost to no_std too.

[cwfitzgerald]

@bushrat011899 To be extremely pedantic and annoying, you need it to be a sealed trait for it to be fully additive - otherwise users could do impl AsPath for MyType where MyType: AsRef<Path> and it's fine with the std feature but not fine without it.

[ErichDonGubler]

@cwfitzgerald: Just pushed up a commit to fix that up, along with some other (perhaps opinionated) changes. PTAL? 😀

[cwfitzgerald]

One documentation note, g2g after that.

[cwfitzgerald]

This is subtlly different - I think we should just list out the types here, as this sounds like it's where for<'a> Cow<'a, str>: From<T> or so