Skip to content

Fix typing for select#7572

Merged
ErichDonGubler merged 2 commits intogfx-rs:trunkfrom
erichdongubler-mozilla:auto-type-conv-for-select-args
Jun 11, 2025
Merged

Fix typing for select#7572
ErichDonGubler merged 2 commits intogfx-rs:trunkfrom
erichdongubler-mozilla:auto-type-conv-for-select-args

Conversation

@ErichDonGubler
Copy link
Copy Markdown
Member

@ErichDonGubler ErichDonGubler commented Apr 18, 2025 •
edited by jimblandy
Loading

Connections

Testing

Tests have been added, as well as a test run against webgpu:shader,execution,expression,call,builtin,select:* in a locally modified Firefox.

Squash or Rebase?

rebase plz

Checklist

  • If this contains user-facing changes, add a CHANGELOG.md entry.

@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch from 991856b to cfd29df Compare April 18, 2025 20:48
@jimblandy

This comment was marked as resolved.

Sign in to view
@jimblandy

This comment was marked as resolved.

Sign in to view
@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch from cfd29df to c6dcb79 Compare April 19, 2025 03:38
@ErichDonGubler

This comment was marked as resolved.

Sign in to view
@ErichDonGubler

This comment was marked as resolved.

Sign in to view
@jimblandy

This comment was marked as resolved.

Sign in to view
@jimblandy

This comment was marked as resolved.

Sign in to view
@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch from c6dcb79 to 62c8609 Compare April 21, 2025 15:56
@ErichDonGubler ErichDonGubler mentioned this pull request Apr 23, 2025
Closed
1 task
@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch 2 times, most recently from 2de9a82 to 83ad8bb Compare April 23, 2025 16:07
@ErichDonGubler

This comment was marked as resolved.

Sign in to view
@ErichDonGubler ErichDonGubler changed the title WIP: fix(naga): properly impl. auto. type conv. for select fix(naga): properly impl. auto. type conv. for select Apr 23, 2025
@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch 2 times, most recently from db91e44 to 2f271ab Compare April 29, 2025 02:15
jimblandy

This comment was marked as resolved.

Sign in to view

@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch 2 times, most recently from d792084 to 817989b Compare April 29, 2025 20:18
@ErichDonGubler

This comment was marked as resolved.

Sign in to view
@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch 2 times, most recently from 6db2cc1 to 6e62829 Compare May 1, 2025 21:14
@ErichDonGubler ErichDonGubler mentioned this pull request May 1, 2025
Merged
1 task
@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch from 6e62829 to 88fa2bb Compare May 1, 2025 22:04
ErichDonGubler
ErichDonGubler commented May 2, 2025
View reviewed changes
Comment thread naga/src/proc/constant_evaluator.rs
ErichDonGubler
ErichDonGubler commented May 2, 2025
View reviewed changes
Comment thread naga/src/valid/expression.rs
@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch 2 times, most recently from dd40727 to 1881436 Compare May 2, 2025 01:39
@ErichDonGubler ErichDonGubler marked this pull request as ready for review May 2, 2025 01:40
@ErichDonGubler ErichDonGubler changed the title fix(naga): properly impl. auto. type conv. for select Fix typing for select May 2, 2025
@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch from 1881436 to 4c8503b Compare May 2, 2025 01:45
jimblandy

This comment was marked as resolved.

Sign in to view

jimblandy
jimblandy reviewed May 22, 2025
View reviewed changes
Comment thread naga/src/front/wgsl/lower/mod.rs
jimblandy
jimblandy reviewed May 22, 2025
View reviewed changes
Comment thread naga/src/front/wgsl/lower/mod.rs Outdated
@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch 2 times, most recently from 291d321 to 0da4827 Compare May 22, 2025 15:52
@ErichDonGubler ErichDonGubler requested review from a team and crowlKats as code owners May 22, 2025 16:38
@ErichDonGubler

This comment was marked as resolved.

Sign in to view
@cwfitzgerald cwfitzgerald assigned teoxoy and unassigned jimblandy May 28, 2025
@cwfitzgerald cwfitzgerald marked this pull request as draft May 28, 2025 15:13
@teoxoy teoxoy removed their assignment Jun 4, 2025
@ErichDonGubler ErichDonGubler marked this pull request as ready for review June 6, 2025 07:33
@ErichDonGubler
Copy link
Copy Markdown
Member Author

ErichDonGubler commented Jun 6, 2025

Marking this as ready for review, since the approach has been validated and it is in de-facto late stages of review.

@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch from f001acc to bab4369 Compare June 6, 2025 08:05
@ErichDonGubler ErichDonGubler requested a review from jimblandy June 6, 2025 08:05
jimblandy
jimblandy approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to land, with the following changes.

Comment thread naga/src/front/wgsl/lower/mod.rs Outdated
Comment thread naga/src/front/wgsl/lower/mod.rs Outdated
Comment thread naga/src/front/wgsl/lower/mod.rs Outdated
Comment thread naga/src/front/wgsl/lower/mod.rs Outdated
@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch from bab4369 to ccca440 Compare June 11, 2025 09:37
@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch from a1a660e to 2036853 Compare June 11, 2025 09:43
ErichDonGubler
ErichDonGubler commented Jun 11, 2025
View reviewed changes
Comment thread cts_runner/test.lst Outdated
@ErichDonGubler ErichDonGubler force-pushed the auto-type-conv-for-select-args branch from 2036853 to e477ad9 Compare June 11, 2025 12:42
@ErichDonGubler ErichDonGubler enabled auto-merge (rebase) June 11, 2025 12:43
@ErichDonGubler ErichDonGubler merged commit db3c35d into gfx-rs:trunk Jun 11, 2025
40 checks passed
@ErichDonGubler ErichDonGubler deleted the auto-type-conv-for-select-args branch June 11, 2025 12:55
@ErichDonGubler ErichDonGubler mentioned this pull request Jun 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimblandy jimblandy jimblandy approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

Assignees

@jimblandy jimblandy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automatic type conversion not working for select

3 participants

@ErichDonGubler @jimblandy @teoxoy