Implement ray query candidate intersection generation and confirmation #7047
Conversation
kvark
force-pushed
the
rt-confirm
branch
3 times, most recently
from
9d50d75 to
8cbea73
Compare
kvark
force-pushed
the
rt-confirm
branch
4 times, most recently
from
970b0bf to
16c902b
Compare
| @@ -2,23 +2,23 @@ | |||
|
|
|||
| 🧪Experimental🧪 | |||
|
|
|||
| `wgpu` supports an experimental version of ray tracing which is subject to change. The extensions allow for acceleration structures to be created and built (with | |||
There was a problem hiding this comment.
It might not be helpful to have these formatting changes.
There was a problem hiding this comment.
Looks harmless though? Also, unintentional - my editor made them automatically.
There was a problem hiding this comment.
Yeah, but it made it slower to figure out what had changed. Personally I don't think this really needs to be fixed as it would be difficult but it might be worth turning that feature off in your editor if possible.
There was a problem hiding this comment.
While I agree, I think most people nowadays have whitespace stripping in their editors. Github also highlights only the whitespace being removed but it does clutter the blame.
It would be nice to not have trailing whitespace in files from the beginning but we decided against adding a CI check for that #6368 (comment).
Related: long term we would like to do these changes in bulk prior to releasing #6973.
In conclusion, I'd say these removals of whitespace are fine even though not ideal, they would either happen now or prior to a release.
| @@ -30,6 +30,7 @@ const RT_NAMESPACE: &str = "metal::raytracing"; | |||
| const RAY_QUERY_TYPE: &str = "_RayQuery"; | |||
| const RAY_QUERY_FIELD_INTERSECTOR: &str = "intersector"; | |||
| const RAY_QUERY_FIELD_INTERSECTION: &str = "intersection"; | |||
| const RAY_QUERY_MODERN_SUPPORT: bool = false; //TODO | |||
There was a problem hiding this comment.
It would be worth opening a new issue to track the transition to the new API.
|
@Vecvec thanks for taking a look at this! |
Connections
Fixes #6759
Description
Implements missing functionality for working with candidate intersections.
These functions are only functional in SPIR-V and HLSL.
Metal doesn't appear to expose this in the "old" API - we need to hook up their newer ray query objects.
Testing
Just shader validation. The function signatures are fairly straightforward.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.