Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds hello window example #6992

Merged
merged 10 commits into from
Jan 27, 2025
Merged

Adds hello window example #6992

merged 10 commits into from
Jan 27, 2025
+674 −35

Conversation

laycookie
Copy link
Contributor

@laycookie laycookie commented Jan 26, 2025 •
edited
Loading

Connections
Implements #6991

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@laycookie
Adds hello window example
b359985 
Adds hello window example

Adds hello window example

Adds hello window example
@laycookie laycookie requested a review from a team as a code owner January 26, 2025 04:17
@laycookie laycookie requested a review from kpreid January 26, 2025 04:39
kpreid
kpreid reviewed Jan 26, 2025
View reviewed changes
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Show resolved Hide resolved
cwfitzgerald
cwfitzgerald requested changes Jan 26, 2025
View reviewed changes
examples/standalone/02_hello_window/Cargo.toml Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
cwfitzgerald
cwfitzgerald approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to add some more commentary, but I can do this as a follow up PR.

Thanks for the work here!

examples/standalone/02_hello_window/src/main.rs Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) January 27, 2025 01:57
@cwfitzgerald cwfitzgerald merged commit 0e7d93e into gfx-rs:trunk Jan 27, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpreid kpreid kpreid requested changes

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laycookie @kpreid @cwfitzgerald