[naga] Use cfg aliases to enable naga::back::continue_forward.
#6064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
added
area: naga back-end
jimblandy
force-pushed
the
naga-cfg-continue-forward
branch
from
76f9f07 to
6407ec6
Compare
|
Obrigado por dar uma olhada! |
jimblandy
force-pushed
the
naga-cfg-continue-forward
branch
from
6407ec6 to
a72cae2
Compare
Rather than `feature = "blah"`, use the new `cfg` identifiers introduced by the `cfg_aliases` invocation in `naga/build.rs` to decide whether to compile the `naga::back::continue_forward` module, which is only used by the GLSL and HLSL backends. The `hlsl_out` `cfg` identifer has a more complex condition than just `feature = "hlsl-out"`, introduced by gfx-rs#5919. Fixes gfx-rs#6063.
jimblandy
force-pushed
the
naga-cfg-continue-forward
branch
from
a72cae2 to
4403413
Compare
teoxoy
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than
feature = "blah", use the newcfgidentifiers introduced by thecfg_aliasesinvocation innaga/build.rsto decide whether to compile thenaga::back::continue_forwardmodule, which is only used by the GLSL and HLSL backends.The
hlsl_outcfgidentifer has a more complex condition than justfeature = "hlsl-out", introduced by #5919.Fixes #6063.