-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate CMake distribution in CD #251
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This sounds like it would be useful, but (being mostly a Python dev) I cannot judge whether this approach is good practice or something like that.
Co-authored-by: Almar Klein <[email protected]>
…pu-native into feature-cmake-distribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed a spot :)
Co-authored-by: Almar Klein <[email protected]>
Co-authored-by: Almar Klein <[email protected]>
Oh thanks my bad! |
…pu-native into feature-cmake-distribution
This is open for a while even though this is about finished. I think this needs a round of review from someone with more experience (than me) in build systems. cc @rajveermalviya |
Is there something I can do to help push this along? |
@rajveermalviya Any chance I can help get this wrapped up for the next release? |
(Apologies for missing this) Tbh instead of this, I would prefer a setup where user can clone the repo (or github's download zip) to a directory and then import that directory via Then the But not really sure how emscripten would fit in that. |
I agree actually, not my topmost priority at the moment but I'll work on this eventually! |
|
I have a working prototype of this locally now. I'll need #359 to land and then I can start on a series of PRs that get us to (what I hope is) a good place. |
Hello,
I am trying to make the integration of the precompiled binaries in a CMake-based project as easy and portable as possible for my WebGPU C++ guide and I came up with a solution that satisfies me:
webgpu
CMake target to link like any library and that manages the pre-compiled binariesWEBGPU_BACKEND_WGPU
to distinguish this distribution for the Dawn-based alternative that I also provideCurrently I point my readers to my WebGPU-distribution repository but I think this is something that would be worth making available directly in the release of
wgpu-native
.This PR adds to the CD process the generation of a distribution of WebGPU that can be simply copied in a CMake project and integrated with
add_subdirectory(webgpu)
. More info to be found in distribution/REAMD.md.This is something that I am going to also discuss with Dawn so that ideally we end up with a common way of packaging binaries for CMake. I'll be happy to discuss the details and adapt to as many use cases as possible!