Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add llvm syntax highlighting #2268

Closed

Conversation

michaelmaitland
Copy link

Closes #2267

@Keats
Copy link
Collaborator

Keats commented Dec 17, 2023

Thanks for the PR. I'm not going to add more built in syntaxes for now while we're looking at alternatives for highlighters.

@Keats Keats closed this Dec 17, 2023
@michaelmaitland
Copy link
Author

michaelmaitland commented Dec 17, 2023

That’s unfortunate. Do you have any reason why we can’t add it today and remove it when we have an alternative syntax highlighting solution implemented? By that logic let’s remove all syntax highlighting for all languages since we’re looking into rehauling syntax highlighting that might get implemented one day.

@Keats
Copy link
Collaborator

Keats commented Dec 17, 2023

It's trivial to add syntaxes as an end user.

By that logic let’s remove all syntax highlighting for all languages since we’re looking into rehauling syntax highlighting that might get implemented one day.

Let's not add more when the future is uncertain, no reason to break more stuff people rely on.

@michaelmaitland
Copy link
Author

michaelmaitland commented Dec 17, 2023

It's trivial to add syntaxes as an end user

can you link to this? I don’t know how to do this without maintaining my own downstream zola repo and build.

no reason to break more stuff people rely on

is there a reason why you think this change would break anything? It looks like zola has a clear track record of adding new languages without introducing any new problems. Why would this be any different?

@Keats
Copy link
Collaborator

Keats commented Dec 17, 2023

In https://www.getzola.org/documentation/content/syntax-highlighting/ search for extra_syntaxes_and_themes

Why would this be any different?

We're looking at tree-sitter in #1787 which supports fewer languages than Sublime, or sometimes they support it but the parser is 100MB and I'm not going to add it to Zola because it's too big.

@michaelmaitland
Copy link
Author

#1787 has been open for 1,5 years and the work you need from tree-sitter does not look like it is actively being worked on nor is there a timeline for its completion.

The link you sent me to says to make a PR to add a syntax.

If the language you want to highlight is not on this list, please follow our contribution guidelines to add support for a new language.

It’s a small syntax I’m adding and there’s a very low chance it’s going to break anything based on the fact that we’re following an established method of adding syntax’s that hasn’t caused problems in the last.

I’m asking for you to make the change in the interim while you figure out tree-sitter, based on the instructions in the documentation you linked me of how to add a new syntax.

@Keats
Copy link
Collaborator

Keats commented Dec 17, 2023

I've just updated the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add syntax highlighting for llvm
2 participants