fix: OpenAIRerankerClient now properly supports AzureOpenAILLMClient #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated type detection to use BaseOpenAIClient instead of OpenAIClient - This allows both OpenAIClient and AzureOpenAILLMClient to be properly unwrapped - Added comprehensive test coverage for all client types - Fixes getzep#1006
supmo668
had a problem deploying
to
development
GitHub Actions
Failure
Member
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
supmo668
had a problem deploying
to
development
GitHub Actions
Failure
Fixes pyright type checking error by declaring the client attribute in the base class. All concrete implementations (OpenAIClient, AzureOpenAILLMClient, OpenAIGenericClient) initialize this attribute, and it needs to be accessible for type checking in OpenAIRerankerClient. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #1006 where
OpenAIRerankerClientfailed to properly supportAzureOpenAILLMClient.Problem
The
OpenAIRerankerClientonly checked forOpenAIClientinstances when unwrapping the client, causingAzureOpenAILLMClientto be passed through without unwrapping. This resulted in:Solution
Updated the type detection to use
BaseOpenAIClientwhich is the parent class of bothOpenAIClientandAzureOpenAILLMClient. This allows both client types to be properly unwrapped to their underlyingAsyncOpenAIorAsyncAzureOpenAIinstances.Changes
graphiti_core/cross_encoder/openai_reranker_client.py:BaseOpenAIClientOpenAIClienttoBaseOpenAIClientisinstancecheck to useBaseOpenAIClienttests/cross_encoder/test_openai_reranker_client.py:OpenAIClientcompatibility (regression test)AzureOpenAILLMClientcompatibility (fixes [BUG] OpenAIRerankerClient does not support AzureOpenAILLMClient #1006)AsyncOpenAIusagerank()method with Azure clientTesting
All tests pass:
Fixes #1006