-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added egs for groups fxns; also reexporting magrittr pipe so its avai… #82
Conversation
…l in egs when package sixtyfour is loaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Whelp CI isn't happy! I tried running
|
Thanks. Yeah we've thus far had dummy aws access key and secret key b/c we just needed any string to run the package for those env vars, but if we try to run examples for real of course those don't work. so thinking about whether to just skip examples on CI or run them but take precautions. |
My instinct is that software testing that costs money (hits the aws api for real) should not be automated, at least at this point in the trajectory of this project. Maybe we'd do it in the future though. |
yeah, good thinking, yeah think i'll just skip egs on CI then. It'd be cool to run examples against minio/localstack, and I can see about doing that locally for running egs and generating pkgdown docs - but it wouldn't make sense to do if it requires code in the examples to do that since users aren't going to spin up those two services to run examples. |
@seankross For the |
#68
Series of PRs for re-working examples.
Groups set of fxns
Also reexporting magrittr pipe here