Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added egs for groups fxns; also reexporting magrittr pipe so its avai… #82

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

sckott
Copy link
Member

@sckott sckott commented Jan 22, 2025

#68

Series of PRs for re-working examples.

Groups set of fxns

Also reexporting magrittr pipe here

@sckott sckott added this to the v0.2 milestone Jan 22, 2025
@sckott sckott requested a review from seankross January 22, 2025 23:43
seankross
seankross previously approved these changes Jan 23, 2025
Copy link
Collaborator

@seankross seankross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@seankross seankross self-requested a review January 23, 2025 16:04
@seankross seankross dismissed their stale review January 23, 2025 16:04

CI issues

@seankross
Copy link
Collaborator

Whelp CI isn't happy! I tried running test() locally and got this error, which is different than the error gha is throwing:

── Failed tests ────────────────────────────────────────────────────────────
Error (test-billing.R:5:5): aws_billing
Error in `including(list(Metrics = list("UnblendedCost")))`: could not find function "including"
Backtrace:
    ▆
 1. ├─withr::with_package(...) at test-billing.R:2:3
 2. │ └─base::force(code)
 3. ├─webmockr::to_return(...) at test-billing.R:5:5
 4. │ └─webmockr:::assert(.data, "StubbedRequest")
 5. └─webmockr::wi_th(...)

[ FAIL 1 | WARN 0 | SKIP 10 | PASS 151 ]

@sckott
Copy link
Member Author

sckott commented Jan 23, 2025

Thanks. Yeah we've thus far had dummy aws access key and secret key b/c we just needed any string to run the package for those env vars, but if we try to run examples for real of course those don't work. so thinking about whether to just skip examples on CI or run them but take precautions.

@seankross
Copy link
Collaborator

seankross commented Jan 23, 2025

My instinct is that software testing that costs money (hits the aws api for real) should not be automated, at least at this point in the trajectory of this project. Maybe we'd do it in the future though.

@sckott
Copy link
Member Author

sckott commented Jan 24, 2025

software testing that costs money (hits the aws api for real) should not be automated,

yeah, good thinking, yeah think i'll just skip egs on CI then.

It'd be cool to run examples against minio/localstack, and I can see about doing that locally for running egs and generating pkgdown docs - but it wouldn't make sense to do if it requires code in the examples to do that since users aren't going to spin up those two services to run examples.

@sckott
Copy link
Member Author

sckott commented Jan 29, 2025

@seankross For the webmockr error, the dev version is specified in Remotes in DESCRIPTION file, guessing that locally you have to install it manually pak::pak("ropensci/webmockr")

@sckott sckott merged commit 58ab2e1 into dev Jan 29, 2025
7 checks passed
@sckott sckott deleted the egs-groups branch January 29, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants