Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional functions for files #22

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Additional functions for files #22

merged 3 commits into from
Dec 13, 2023

Conversation

sckott
Copy link
Member

@sckott sckott commented Dec 12, 2023

  • rename
  • copy
  • pull create bucket if it doesn't exist into a helper fxn
  • helpers: path_s3_build to build the output from path_s3_parse (renamed); and add path_as_s3

@seankross
Copy link
Collaborator

This looks good to me, are you looking for any specific feedback? If not, you should go ahead and merge.

@sckott
Copy link
Member Author

sckott commented Dec 13, 2023

Thanks. No specific feedback.

@sckott sckott merged commit 27f391b into main Dec 13, 2023
7 checks passed
@sckott sckott deleted the s3-fxns branch December 13, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sckott @seankross