Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: RustDesk Server #2169

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Knufle
Copy link

@Knufle Knufle commented Feb 7, 2025

App Submission

RustDesk Server

This PR adds RustDesk server to Umbrel. RustDesk is an open-source remote desktop software that allows secure remote connections.

The server consists of two components:

  • hbbs (ID/Rendezvous server)
  • hbbr (Relay server)

Both components are required for proper functionality and are included in this deployment.

256x256 SVG icon

https://limewire.com/d/ceee5ca3-4cfd-4d82-ba71-a0af37693c14#yLGrXJICd91f3YfXMUzWZgJR8tmMIhcXtc0DZn75uLk

Gallery images

There's no image to be shown here since it's all server

I have tested my app on:

  • umbrelOS on a Raspberry Pi
  • umbrelOS on an Umbrel Home
  • umbrelOS on Linux VM

Copy link

github-actions bot commented Feb 7, 2025

❌   Linting failed with 5 errors and 3 warnings   ❌

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
rustdesk/docker-compose.yml Invalid image name "rustdesk/rustdesk-server@sha256:680f8ba5accafc264d15076f33a6fdb9cb6f4d963a0fc92e01023ca0e919cc83":
Images should be named like "<name>:<version-tag>@<sha256>"
rustdesk/docker-compose.yml Invalid image name "rustdesk/rustdesk-server@sha256:680f8ba5accafc264d15076f33a6fdb9cb6f4d963a0fc92e01023ca0e919cc83":
Images should be named like "<name>:<version-tag>@<sha256>"
ℹ️ rustdesk/docker-compose.yml Potentially using unsafe user in service "hbbs":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
ℹ️ rustdesk/docker-compose.yml Potentially using unsafe user in service "hbbr":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
ℹ️ rustdesk/docker-compose.yml Service "hbbs" uses host network mode:
The host network mode can lead to security vulnerabilities. If possible please use the default bridge network mode and expose the necessary ports.
ℹ️ rustdesk/docker-compose.yml Service "hbbr" uses host network mode:
The host network mode can lead to security vulnerabilities. If possible please use the default bridge network mode and expose the necessary ports.
⚠️ rustdesk/docker-compose.yml Invalid restart policy:
The restart policy of the container "hbbs" should be set to "on-failure".
⚠️ rustdesk/docker-compose.yml Invalid restart policy:
The restart policy of the container "hbbr" should be set to "on-failure".
rustdesk/umbrel-app.yml category:
Invalid enum value. Expected 'files' | 'bitcoin' | 'media' | 'networking' | 'social' | 'automation' | 'finance' | 'ai' | 'developer', received 'utilities'
rustdesk/umbrel-app.yml Invalid submission field "https://github\.com/getumbrel/umbrel\-apps/pull/xxx":
The submission field must be set to the URL of this pull request: https://github\.com/getumbrel/umbrel\-apps/pull/2169
rustdesk/umbrel-app.yml "releaseNotes" needs to be empty for new app submissions:
The "releaseNotes" field must be empty for new app submissions as it is being displayed to the user only in case of an update.
⚠️ rustdesk/umbrel-app.yml "icon" and "gallery" needs to be empty for new app submissions:
The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant