-
Notifications
You must be signed in to change notification settings - Fork 988
feat(hckms): Add HuaweiCloud KMS support #2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f2bf283 to
764c31e
Compare
sabre1041
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. Would you be able to address the conflicted files?
Signed-off-by: Enbiya Goral <[email protected]>
06f11d7 to
72e903e
Compare
Signed-off-by: Enbiya Göral <[email protected]>
Yes, I’ve gone ahead and resolved the conflicted files @sabre1041 |
sabre1041
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the contribution!
Thanks a lot for the review and approval @sabre1041 |
|
Please note that the tests are failing. You should also update the documentation (README.rst) accordingly. |
Signed-off-by: Enbiya Goral <[email protected]>
Thanks! I’ve added the HuaweiCloud KMS documentation to the README.rst file. The CI failures are happening because these changes haven’t been committed yet (the “clean working tree” check is failing). @felixfontein |
Add HuaweiCloud KMS Support
Closes #2000
Summary
This PR adds support for encrypting and decrypting SOPS files using HuaweiCloud KMS, similar to existing AWS KMS, GCP KMS, and Azure Key Vault integrations.
Changes
Core Implementation
hckmspackage implementingMasterKeyinterface for HuaweiCloud KMSCLI Integration
--hckmsflag forencryptandeditcommands--add-hckmsand--rm-hckmsflags forrotatecommandSOPS_HUAWEICLOUD_KMS_IDSenvironment variableConfiguration Support
.sops.yamlconfiguration filesregion:key-uuid(e.g.,cn-north-1:12345678-1234-1234-1234-123456789abc)gRPC Keyservice Integration
HckmsKeymessage to protobuf definitionsStorage Format
hckmskey serialization instorespackageUsage
Configuration File Example
Authentication
HuaweiCloud credentials can be provided via:
HUAWEICLOUD_SDK_AK,HUAWEICLOUD_SDK_SK,HUAWEICLOUD_SDK_PROJECT_ID~/.huaweicloud/credentialsTesting
Implementation Notes
region:key-uuidwhere region is the HuaweiCloud region identifier