Skip to content

Update disks.md (EFI partition size) #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update disks.md (EFI partition size) #644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/user/quick-start/installation/disks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Alongside these options, we also provide the ability to use full-disk encryption

If you are using a system with UEFI, you may need to create an EFI System Partition, also referred to as an ESP. This is not necessary if you are enabling Solus to install onto the entire disk.

To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1 GB in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags.
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1 GiB (= 1024 MiB) in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1 GiB (= 1024 MiB) in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags.
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1 GiB (= 1024 MiB) in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags.

Please also add a non-breaking space before the new value

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, maybe this should also use the same or a similar form as the table in System Requirements, for consistency's sake.

That is, something like 1.08 GB / 1 GiB

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you would prefer 1.08 GB / 1 GiB / 1024 MiB instead of 1 GiB (= 1024 MiB) ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, to be honest. Someone with a sense of aesthetics please give your input! ^^

In any case this shouldn't be a hold-up for getting this clarification / error correction in, so as long as you add the non-breaking space and also add the same change to the System Requirements doc I think it should be fine to merge.

Copy link
Contributor

@deoxys94 deoxys94 Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is a tricky/interesting question.

  • In disks.md use 1024 MiB only, don't add any equivalents or conversions (GParted shows MiB in the UI, adding the GiB conversion is not really necessary or helpful)
  • The tricky part comes for the system requirements. In that file, I'd say leave it as 1 GB because:
    • Drives are usually rated in GB
    • The exact size for the EFI partition is only relevant to people who choose to install Solus manually. That people will eventually read disks.md to see the exact number they need

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the first part. For the second part I'd still change it though, otherwise it's simply wrong. Perhaps only show the 1 GiB value there (because the exact GB value is ugly)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another option: Removing that line from the requirements page, like this:

The rationale: Users reading the system requirements page only need to know if their system as a whole meets the requirements to run the operating systems. The users who need to know the exact size of the EFI partition are the ones who want to install everything manually, and that kind of users will eventually land in disks.md

Copy link
Contributor

@deoxys94 deoxys94 Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1 GiB (= 1024 MiB) in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags.
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1024 MiB in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags.


**Notes:**

Expand Down
Loading