Skip to content

Conversation

@evanh
Copy link
Member

@evanh evanh commented Jan 6, 2026

This trait currently only has a SQLite implementation, but in the future we can add other implementations like AlloyDB and the stateless taskbroker.

Future iterations on this trait might also remove some functions (e.g. vacuum_db) but for now the trait simply used every public function.

This trait currently only has a SQLite implementation, but in the future we can add other
implementations like AlloyDB and the stateless taskbroker.

Future iterations on this trait might also remove some functions (e.g. vacuum_db) but for now the
trait simply used every public function.
@evanh evanh requested a review from a team as a code owner January 6, 2026 21:15
@evanh
Copy link
Member Author

evanh commented Jan 7, 2026

I'm not sure what's going on with the integration test. The failure is from Task grpc_server failed: GRPC server task failed: tonic::transport::Error(Transport, Os { code: 98, kind: AddrInUse, message: "Address already in use" }). I can't reproduce this locally. I'm going to play around with the ports to see if that fixes things.

Update: fixed

@evanh evanh merged commit 0b48178 into main Jan 8, 2026
18 checks passed
@evanh evanh deleted the evanh/fix/create-activation-store-trait branch January 8, 2026 16:06
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants