-
-
Notifications
You must be signed in to change notification settings - Fork 3
feat(store): Create a trait for the taskbroker store #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This trait currently only has a SQLite implementation, but in the future we can add other implementations like AlloyDB and the stateless taskbroker. Future iterations on this trait might also remove some functions (e.g. vacuum_db) but for now the trait simply used every public function.
|
I'm not sure what's going on with the integration test. The failure is from Update: fixed |
markstory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This trait currently only has a SQLite implementation, but in the future we can add other implementations like AlloyDB and the stateless taskbroker.
Future iterations on this trait might also remove some functions (e.g. vacuum_db) but for now the trait simply used every public function.