ref(storage-routing): make long term retention downsampling the default - #8235
Open
phacops wants to merge 1 commit into
Open
ref(storage-routing): make long term retention downsampling the default#8235phacops wants to merge 1 commit into
phacops wants to merge 1 commit into
Conversation
Removes the `enable_long_term_retention_downsampling` option and makes its behavior unconditional: in `OutcomesBasedRoutingStrategy`, EAP queries whose window starts more than 31 days ago are always routed to TIER_8, unless the item type is in `ITEM_TYPE_FULL_RETENTION` (uptime results and preprod, which keep their full-retention tier 1 data). - `outcomes_based.py`: drop the `get_option` gate (and the now-unused import). - `sentry-options/schemas/snuba/schema.json`: drop the option definition. - tests: drop the `override_options` decorators that turned it on, and update `test_outcomes_based_routing_queries_daily_table` — its 100-day window now downsamples to TIER_8 rather than staying on TIER_1. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTDth91JqESZnzKKRoFoKJ
pbhandari
approved these changes
Jul 29, 2026
phacops
enabled auto-merge (squash)
July 29, 2026 14:42
k-fish
approved these changes
Jul 30, 2026
pbhandari
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
enable_long_term_retention_downsamplingoption and makes its behavior unconditional. InOutcomesBasedRoutingStrategy, EAP queries whose window starts more than 31 days ago are always routed toTIER_8, unless the item type is inITEM_TYPE_FULL_RETENTION(uptime results and preprod, which keep their full-retention tier 1 data).outcomes_based.py: drop theget_optiongate and the now-unused import.sentry-options/schemas/snuba/schema.json: drop the option definition.override_optionsdecorators that turned it on, and updatetest_outcomes_based_routing_queries_daily_table— its 100-day window now downsamples toTIER_8rather than staying onTIER_1.Note: if
enable_long_term_retention_downsamplingis still set in the deployed options, that entry becomes unknown once this schema change lands and should be cleaned up. The read path swallowsOptionsError, so Snuba itself is unaffected.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Generated by Claude Code