fix(get_traces): make cross-item query limit explicit and configurable #7677
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, get_trace_ids_sql_for_cross_item_query extracted the limit from the original request, but different endpoints have different semantics for their limit fields. This changes the function to take an explicit limit parameter instead. Changes: - Add optional limit parameter to get_trace_ids_sql_for_cross_item_query - EndpointGetTraces now passes its request limit explicitly - EndpointTimeSeries and EndpointTraceItemTable use default limit - Make default limit runtime configurable via state.get_config The trace limit can now be configured at runtime using the trace_ids_cross_item_query_limit config key, with a default of 10,000. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
phacops
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, get_trace_ids_sql_for_cross_item_query extracted the limit from the original request, but different endpoints have different semantics for their limit fields. This changes the function to take an explicit limit parameter instead.
The impact of this was a data bug where
TraceItemTablerequests with cross item queries only had one or two span samples when there were actually thousands:Changes:
The trace limit can now be configured at runtime using the trace_ids_cross_item_query_limit config key, with a default of 10,000.