ref(uptime): Detector always exists

[evanpurkhiser]

No description provided.

[cursor]

Bug: Task Crashes on Missing Detector

The broken_monitor_checker task crashes with an unhandled Detector.DoesNotExist exception when get_detector() is called for an UptimeSubscription that lacks a detector. This regression occurred because the assert detector check was removed, and get_detector() now raises an exception instead of returning None. The crash prevents the task from processing remaining subscriptions and disabling other broken monitors. The task should handle this exception to gracefully skip subscriptions without detectors.

src/sentry/uptime/subscriptions/tasks.py#L231-L235

sentry/src/sentry/uptime/subscriptions/tasks.py

Lines 231 to 235 in 31a2eb8

	):
	detector = get_detector(uptime_subscription)
	if detector.config["mode"] == UptimeMonitorMode.AUTO_DETECTED_ACTIVE:
	disable_uptime_detector(detector)
	count += 1

Fix in Cursor

---

Bug: Unhandled Exceptions Break Delete Functionality

Removing assert detector without adding exception handling for get_detector() (which now raises Detector.DoesNotExist) causes unhandled exceptions, leading to crashes if the detector does not exist. This breaks functionality, including the delete endpoint.

src/sentry/uptime/subscriptions/subscriptions.py#L326-L327

sentry/src/sentry/uptime/subscriptions/subscriptions.py

Lines 326 to 327 in 31a2eb8

	detector = get_detector(uptime_monitor.uptime_subscription)

src/sentry/uptime/endpoints/project_uptime_alert_details.py#L124-L125

sentry/src/sentry/uptime/endpoints/project_uptime_alert_details.py

Lines 124 to 125 in 31a2eb8

	"""
	detector = get_detector(uptime_subscription.uptime_subscription)

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #94571   +/-   ##
=======================================
  Coverage   87.94%   87.94%           
=======================================
  Files       10405    10405           
  Lines      602418   602387   -31     
  Branches    23446    23446           
=======================================
- Hits       529803   529784   -19     
+ Misses      72110    72098   -12     
  Partials      505      505