feat(aci): add more action nodes #91607
Conversation
github-actions
bot
added
the
Scope: Frontend
ameliahsu
force-pushed
the
mia/aci/action-nodes-2
branch
from
9dd40b7 to
a0504d5
Compare
| useEffect(() => { | ||
| fetchOrgMembers(api, organization.slug); | ||
| }, [api, organization]); |
There was a problem hiding this comment.
we need this for the SelectMembers component in the email action to properly load
There was a problem hiding this comment.
In that case, is there any way to move this to the email action component itself? This feels out of place when scanning this file, especially without a comment.
There was a problem hiding this comment.
I originally had this in the email action component, but then I realized that this would be called for each instance of the component vs. having this at the top-level within the automation builder, where it would only get called once. We will also need the org members data for one of the data condition nodes (screenshot below). Let me know if you still think it should be within the component!
There was a problem hiding this comment.
I still think it should be moved down to the component! Ideally this fetch call should be deduplicated by taking advantage of React Query, but that probably needs to be done in a separate PR.
There was a problem hiding this comment.
For now I'd just add an inline comment explaining why this is here
| useEffect(() => { | ||
| fetchOrgMembers(api, organization.slug); | ||
| }, [api, organization]); |
There was a problem hiding this comment.
In that case, is there any way to move this to the email action component itself? This feels out of place when scanning this file, especially without a comment.
static/app/views/automations/components/actions/azureDevOps.tsx
Outdated
Show resolved
Hide resolved
adding more action nodes (azure devops, email, github, github enterprise, jira, jira server, opsgenie, pagerduty, slack) preview [here](https://sentry-73eqbmn2e.sentry.dev/issues/automations/new/settings) <img width="1147" alt="Screenshot 2025-05-13 at 5 28 18 PM" src="https://github.com/user-attachments/assets/e9d8c573-b02f-400a-9194-80514c9975d9" /> ### next to-dos: - still need to refactor the ticketing action modal for the ticketing action nodes to be complete (coming in a future PR) - plugin action - webhook action - sentry app actions
adding more action nodes (azure devops, email, github, github enterprise, jira, jira server, opsgenie, pagerduty, slack)
preview here
next to-dos: