Skip to content

fix(insights): fix issue with fcp and ttfb not rendering properly on eap Webvitals #91591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

fix(insights): fix issue with fcp and ttfb not rendering properly on eap Webvitals #91591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions static/app/views/insights/browser/webVitals/components/pageOverviewWebVitalsDetailPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import type {
import decodeBrowserTypes from 'sentry/views/insights/browser/webVitals/utils/queryParameterDecoders/browserType';
import useProfileExists from 'sentry/views/insights/browser/webVitals/utils/useProfileExists';
import {SampleDrawerBody} from 'sentry/views/insights/common/components/sampleDrawerBody';
import {useInsightsEap} from 'sentry/views/insights/common/utils/useEap';
import {useDomainViewFilters} from 'sentry/views/insights/pages/useFilters';
import {SpanIndexedField, type SubregionCode} from 'sentry/views/insights/types';
import {TraceViewSources} from 'sentry/views/performance/newTraceDetails/traceHeader/breadcrumbs';
Expand All @@ -49,8 +50,8 @@ type Column = GridColumnHeader;

const PAGELOADS_COLUMN_ORDER: GridColumnOrder[] = [
{key: 'id', width: COL_WIDTH_UNDEFINED, name: t('Transaction')},
{key: 'replayId', width: COL_WIDTH_UNDEFINED, name: t('Replay')},
{key: 'profile.id', width: COL_WIDTH_UNDEFINED, name: t('Profile')},
{key: 'replayId', width: COL_WIDTH_UNDEFINED, name: t('Replay')},
{key: 'webVital', width: COL_WIDTH_UNDEFINED, name: t('Web Vital')},
{key: 'score', width: COL_WIDTH_UNDEFINED, name: t('Score')},
];
Expand Down Expand Up @@ -86,6 +87,7 @@ export function PageOverviewWebVitalsDetailPanel({
const routes = useRoutes();
const {replayExists} = useReplayExists();
const domainViewFilters = useDomainViewFilters();
const useEap = useInsightsEap();

const browserTypes = decodeBrowserTypes(location.query[SpanIndexedField.BROWSER_NAME]);
const subregions = location.query[
Expand Down Expand Up @@ -128,7 +130,10 @@ export function PageOverviewWebVitalsDetailPanel({
useTransactionSamplesCategorizedQuery({
transaction: transaction ?? '',
webVital,
enabled: Boolean(webVital) && (!isInp || (!isSpansWebVital && useSpansWebVitals)),
enabled:
Boolean(webVital) &&
!useEap &&
(!isInp || (!isSpansWebVital && useSpansWebVitals)),
browserTypes,
subregions,
});
Expand All @@ -137,7 +142,8 @@ export function PageOverviewWebVitalsDetailPanel({
useSpanSamplesCategorizedQuery({
transaction: transaction ?? '',
webVital,
enabled: Boolean(webVital) && (isInp || (isSpansWebVital && useSpansWebVitals)),
enabled:
Boolean(webVital) && (useEap || isInp || (isSpansWebVital && useSpansWebVitals)),
browserTypes,
subregions,
});
Expand Down Expand Up @@ -331,7 +337,7 @@ export function PageOverviewWebVitalsDetailPanel({
replayId: row.replayId,
id: '', // id doesn't actually matter here. Just to satisfy type.
'transaction.duration':
isInp || (isSpansWebVital && useSpansWebVitals)
useEap || isInp || (isSpansWebVital && useSpansWebVitals)
? row[SpanIndexedField.SPAN_SELF_TIME]
: // @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
row['transaction.duration'],
Expand Down Expand Up @@ -415,7 +421,7 @@ export function PageOverviewWebVitalsDetailPanel({
return (
<NoOverflow>
{eventTarget ? (
<Link to={eventTarget}>{getShortEventId(row.id)}</Link>
<Link to={eventTarget}>{getShortEventId(row.trace)}</Link>
) : (
<span>{getShortEventId(row.id)}</span>
)}
Expand Down Expand Up @@ -465,11 +471,15 @@ export function PageOverviewWebVitalsDetailPanel({
renderBodyCell: renderSpansBodyCell,
}}
/>
) : isSpansWebVital && useSpansWebVitals ? (
) : useEap || (isSpansWebVital && useSpansWebVitals) ? (
<GridEditable
data={spansTableData}
isLoading={isSpansLoading}
columnOrder={SPANS_SAMPLES_COLUMN_ORDER}
columnOrder={
isSpansWebVital && useSpansWebVitals
? SPANS_SAMPLES_COLUMN_ORDER
: PAGELOADS_COLUMN_ORDER
}
columnSortBy={[sort]}
grid={{
renderHeadCell,
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/insights/browser/webVitals/queries/useSpanSamplesCategorizedQuery.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ export function useSpanSamplesCategorizedQuery({

const isLoading = isGoodDataLoading || isMehDataLoading || isBadDataLoading;

const spanSamplesTableData: SpanSampleRowWithScore[] = data.sort(
(a, b) => a.totalScore - b.totalScore
);
const spanSamplesTableData: SpanSampleRowWithScore[] = defined(webVital)
? data.sort((a, b) => a[`${webVital}Score`] - b[`${webVital}Score`])
: data.sort((a, b) => a.totalScore - b.totalScore);

return {
data: spanSamplesTableData,
Expand Down
2 changes: 2 additions & 0 deletions static/app/views/insights/browser/webVitals/queries/useSpanSamplesWebVitalsQuery.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ export function useSpanSamplesWebVitalsQuery({
inpScore: Math.round((row[SpanIndexedField.INP_SCORE_RATIO] ?? 0) * 100),
lcpScore: Math.round((row[SpanIndexedField.LCP_SCORE_RATIO] ?? 0) * 100),
clsScore: Math.round((row[SpanIndexedField.CLS_SCORE_RATIO] ?? 0) * 100),
fcpScore: Math.round((row[SpanIndexedField.FCP_SCORE_RATIO] ?? 0) * 100),
ttfbScore: Math.round((row[SpanIndexedField.TTFB_SCORE_RATIO] ?? 0) * 100),
projectSlug: row[SpanIndexedField.PROJECT],
};
})
Expand Down
4 changes: 1 addition & 3 deletions static/app/views/insights/browser/webVitals/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@ type SpanSampleRow = {
[SpanIndexedField.CLS_SOURCE]?: string;
};

export type SpanSampleRowWithScore = SpanSampleRow & {
totalScore: number;
};
export type SpanSampleRowWithScore = SpanSampleRow & Score;

export type Opportunity = {
opportunity: number;
Expand Down
Loading