Skip to content

feat(trace-tabs): Updating trace toolbar ui #91571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 14, 2025
Merged

feat(trace-tabs): Updating trace toolbar ui #91571

merged 20 commits into from
May 14, 2025
+163 −43

Conversation

Abdkhan14
Copy link
Contributor

@Abdkhan14 Abdkhan14 commented May 13, 2025 •
edited
Loading

Before:
Screenshot 2025-05-13 at 4 04 15 PM

Screenshot 2025-05-13 at 4 04 20 PM

After:

  • Reset button shows up only when timeline is zoomed
Screenshot 2025-05-13 at 4 03 53 PM

Abdullah Khan and others added 17 commits May 5, 2025 19:20
feat(trace-eap-waterfall): Updating trace waterfall preferences
7ce7216
feat(trace-eap-waterfall): Minor cleanup
1cb12b2
feat(trace-eap-waterfall): Fixing tests
034f3a5
feat(trace-eap-waterfall) Adding tabs to trace layout
d99b268
feat(trace-eap-waterfall): Minor iteration
d8d7b76
feat(trace-eap-waterfall): Resolving conflicts
48c6277
feat(trace-eap-waterfall): Minor cleanup
f172eb5
feat(trace-eap-waterfall): Minor iteration
15fdfec
feat(trace-eap-waterfall): Fixing es-lint
90d3e56
feat(trace-eap-waterfall): Fixing es-lint
a3c657c
feat(trace-eap-waterfall): Resolving conflicts
7df67af
feat(trace-eap-waterfall): Resolving conflicts
5702bcf
@Abdkhan14
feat(trace-eap-waterfall): Adding vitals section to tabs layout (#91357)
cba90fb 
<img width="1243" alt="Screenshot 2025-05-09 at 1 46 45 PM"
src="https://github.com/user-attachments/assets/91e993a9-bf5b-4ff1-9a6c-19ab73308186"
/>
========================================================
<img width="1103" alt="Screenshot 2025-05-09 at 1 56 09 PM"
src="https://github.com/user-attachments/assets/421c7fcc-1972-428e-971d-caec54359fc5"
/>

---------

Co-authored-by: Abdullah Khan <[email protected]>
@Abdkhan14
Merge branch 'master' into abdk/trace-layout-tabs
a8a9c4e
feat(trace-tabs): Resolving conflicts
36d8d77
feat(trace-tabs): Fixing typescript error
451d047
feat(trace-tabs): Updating trace toolbar ui
3b3602b
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 13, 2025
@Abdkhan14 Abdkhan14 marked this pull request as ready for review May 13, 2025 20:20
@Abdkhan14 Abdkhan14 requested a review from a team as a code owner May 13, 2025 20:20
@Abdkhan14 Abdkhan14 merged commit ab25be8 into master May 14, 2025
41 checks passed
@Abdkhan14 Abdkhan14 deleted the trace-tools-bar branch May 14, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narsaynorath narsaynorath narsaynorath approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abdkhan14 @narsaynorath