Skip to content

chore(integrations): Changes exception type for missing org integrations, updates assignment sync to halt on this exception #91542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

GabeVillalobos
Copy link
Member

Fixes ECO-507

Updates the exception type raised in the base IntegrationInstallation class to a distinct type, handles this case when choosing an SLO outcome in sync_assignment_outbound tasks to ensure that missing org integrations are treated as halts, not failures.

…ons, updates assignment sync to halt on this exception
@GabeVillalobos GabeVillalobos requested review from a team as code owners May 13, 2025 16:26
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 13, 2025
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #91542       +/-   ##
===========================================
+ Coverage   45.40%   87.64%   +42.23%     
===========================================
  Files       10299    10321       +22     
  Lines      585388   586474     +1086     
  Branches    22602    22602               
===========================================
+ Hits       265804   514013   +248209     
+ Misses     319156    72033   -247123     
  Partials      428      428               

@GabeVillalobos GabeVillalobos merged commit 70c8e92 into master May 15, 2025
60 checks passed
@GabeVillalobos GabeVillalobos deleted the gv/reclassify-missing-org-integrations-as-halt branch May 15, 2025 17:02
Copy link

sentry-io bot commented May 15, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OrganizationIntegrationNotFound: missing org_integration sentry.integrations.tasks.sync_status_outbound View Issue
  • ‼️ OrganizationIntegrationNotFound: missing org_integration sentry.tasks.process_commit_context View Issue
  • ‼️ OrganizationIntegrationNotFound: missing org_integration sentry.integrations.tasks.sync_status_outbound View Issue
  • ‼️ OrganizationIntegrationNotFound: missing org_integration sentry.tasks.process_commit_context View Issue
  • ‼️ OrganizationIntegrationNotFound: missing org_integration /api/0/projects/{organization_id_or_slug}/{proj... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants