feat(alerts): Allow test notifications to include titles #87871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Frontend
This comment was marked as outdated.
This comment was marked as outdated.
leeandher
force-pushed
the
leander/allow-title-on-test-issues
branch
from
37bb294 to
cbe2b85
Compare
leeandher
removed
the
Scope: Backend
Christinarlong
approved these changes
Mar 25, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
Some notifications may change their content depending on the title of the alert. This is the case for PagerDuty as per the change in #87786. For users to better understand what they can expect when using the test notification button, if they've set up an alert name we should use it, that way it'll appear in the test notification as well. If the user is setting up an issue alert for the first time, the test notification will use the label `Test Alert` (per the change here #87786 -- not included in this PR)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notifications may change their content depending on the title of the alert. This is the case for PagerDuty as per the change in #87786. For users to better understand what they can expect when using the test notification button, if they've set up an alert name we should use it, that way it'll appear in the test notification as well.
If the user is setting up an issue alert for the first time, the test notification will use the label
Test Alert(per the change here #87786 -- not included in this PR)