Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issues): Deduplicate highlight browser and runtime #87796

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

scttcper
Copy link
Member

If both are for example "Chrome" deduplicate the browser and runtime contexts

image

If both are for example "Chrome" deduplicate the browser and runtime contexts
@scttcper scttcper requested a review from a team as a code owner March 24, 2025 21:09
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 24, 2025
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge!!

Copy link

codecov bot commented Mar 24, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
10005 2 10003 15
View the top 1 failed test(s) by shortest run time
provisionSubscriptionAction calls api with correct manually invoiced on-demand args
Stack Traces | 1.24s run time
Error: Unable to find an element with the text: Annual. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.select (.../js/sentry-test/selectEvent.tsx:103:80)
    at Object.<anonymous> (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:1080:5)
View the full list of 1 ❄️ flaky tests
provisionSubscriptionAction calls api with correct am3 dynamic sampling args

Flake rate in main: 60.00% (Passed 2 times, Failed 3 times)

Stack Traces | 5.06s run time
Error: thrown: "Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at .../gsAdmin/components/provisionSubscriptionAction.spec.tsx:953:3
    at _dispatchDescribe (.../jest-circus/build/index.js:91:26)
    at describe (.../jest-circus/build/index.js:55:5)
    at Object.<anonymous> (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:14:1)
    at Runtime._execModule (.../jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../jest-runtime/build/index.js:882:12)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@scttcper scttcper merged commit 72202b8 into master Mar 24, 2025
41 checks passed
@scttcper scttcper deleted the scttcper/deduplicate-browser-runtime branch March 24, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants