Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port(seer): Add workflow comparison algorithms to Sentry #87783

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cmanallen
Copy link
Member

No description provided.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 24, 2025
Copy link

codecov bot commented Mar 24, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
391 1 390 11
View the top 1 failed test(s) by shortest run time
::tests.sentry.seer.workflows.compare.test_suspect_attributes
Stack Traces | 0s run time
#x1B[31mImportError while importing test module '.../workflows/compare/test_suspect_attributes.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/importlib/__init__.py#x1B[0m:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
#x1B[1m#x1B[.../workflows/compare/test_suspect_attributes.py#x1B[0m:1: in <module>
    from sentry.seer.workflows.compare import suspect_attributes
#x1B[1m#x1B[.../workflows/compare/__init__.py#x1B[0m:14: in <module>
    from sentry.seer.workflows.compare.processor import DataProcessor
#x1B[1m#x1B[.../workflows/compare/processor.py#x1B[0m:1: in <module>
    import pandas as pd
#x1B[1m#x1B[31mE   ModuleNotFoundError: No module named 'pandas'#x1B[0m#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@cmanallen cmanallen marked this pull request as ready for review March 24, 2025 20:12
@cmanallen cmanallen requested review from a team as code owners March 24, 2025 20:12
@cmanallen
Copy link
Member Author

cmanallen commented Mar 24, 2025

@getsentry/owners-python-build Adding a dependency for pandas and scipy.

I'm waiting to do steps 1-3 until someone approves the usage of these libraries. I don't think it should be an issue to add them but there was some confusion as to whether we were allowed to add these or not.

Comment on lines +41 to 43
pandas>=2.2.3
pandas-stubs>=2.2.3.250308
parsimonious>=0.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per the discussion in slack -- adding these dependencies to sentry is a non-starter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants