-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sentry apps): add slos for issue link req #87775
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #87775 +/- ##
==========================================
+ Coverage 87.73% 87.79% +0.06%
==========================================
Files 9991 9968 -23
Lines 565181 565079 -102
Branches 22276 22146 -130
==========================================
+ Hits 495840 496109 +269
+ Misses 68919 68569 -350
+ Partials 422 401 -21 |
halt_reason = FAILURE_REASON_BASE.format( | ||
SentryAppExternalRequestHaltReason.BAD_RESPONSE | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe make this into a variable and reuse instead of declaring this 3x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same thing with recording the halt 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okes to the reusing of the halt reason, though I think it's okay to keep the halt part since, imo, it's a bit easier to trace, that in this flow we recorded a halt for this use case.
halt_reason = FAILURE_REASON_BASE.format( | ||
SentryAppExternalRequestHaltReason.BAD_RESPONSE | ||
) | ||
extras["error_message"] = str(e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you are already recording the exception as the halt reason, do you also need to add it to extras?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're add the error_message
here to be included in the webhook_context
for the integrator, but yes it's redundant for the context manager.
Very similar to the SelectRequester external request SLOs. This module we send out a request to the 3p telling them this user would like to link their Sentry issue to your ext platform.
The failure modes for this module are almost the same for SelectRequester
We can fail in a few ways here: